-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate devShell
for pre-commit
#4234
Conversation
bb13f85
to
7a8fe7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a question about a snippet that I'm not sure whether is useful to keep or is part of the previous solution.
I think this solution is elegant and simpler, and this is witnessed by the simplifications in the instructions on enabling/disabling it.
87450d7
to
05fb931
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better 🙂
Thank you
That function is now also providing the `pre-commit` `devShell`, so it makes sense to use a more general name.
05fb931
to
d8e71e7
Compare
Co-authored-by: Neil Mayhew <neil.mayhew@iohk.io>
Description
Resolves #4231
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)