Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate devShell for pre-commit #4234

Merged
merged 6 commits into from
Apr 5, 2024
Merged

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Apr 3, 2024

Description

Resolves #4231

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky force-pushed the lucsanszky/remove-precommit branch from bb13f85 to 7a8fe7f Compare April 3, 2024 23:58
@Lucsanszky Lucsanszky marked this pull request as ready for review April 3, 2024 23:58
flake.nix Show resolved Hide resolved
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a question about a snippet that I'm not sure whether is useful to keep or is part of the previous solution.
I think this solution is elegant and simpler, and this is witnessed by the simplifications in the instructions on enabling/disabling it.

@Lucsanszky Lucsanszky force-pushed the lucsanszky/remove-precommit branch 3 times, most recently from 87450d7 to 05fb931 Compare April 4, 2024 16:17
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 🙂
Thank you

@lehins lehins force-pushed the lucsanszky/remove-precommit branch from 05fb931 to d8e71e7 Compare April 4, 2024 19:20
@lehins lehins enabled auto-merge April 4, 2024 19:20
@neilmayhew neilmayhew disabled auto-merge April 4, 2024 19:36
flake.nix Outdated Show resolved Hide resolved
flake.nix Show resolved Hide resolved
Co-authored-by: Neil Mayhew <neil.mayhew@iohk.io>
@neilmayhew neilmayhew enabled auto-merge April 4, 2024 20:11
@neilmayhew neilmayhew merged commit e47a836 into master Apr 5, 2024
15 checks passed
@neilmayhew neilmayhew deleted the lucsanszky/remove-precommit branch April 5, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove precommit hook
4 participants