Imptests: ParameterChange affects ratification for in-flight proposals #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
reviewed
Apr 4, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Apr 4, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Apr 4, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Apr 4, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
aniketd
force-pushed
the
aniketd/parameterchange-affects-proposals
branch
2 times, most recently
from
9c29358
to
95252b7
Compare
lehins
approved these changes
Apr 5, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
aniketd
force-pushed
the
aniketd/parameterchange-affects-proposals
branch
from
95252b7
to
ae45509
Compare
Soupstraw
reviewed
Apr 8, 2024
For DReps and SPOs: 1. Increasing a threshold prevents in-flight proposals that had enough stake in favour before, to fail ratification. 2. Decreasing a threshold ratifies in-flight proposals that didnt have enough stake before.
aniketd
force-pushed
the
aniketd/parameterchange-affects-proposals
branch
from
ae45509
to
d4d1da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4132
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)