Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert small-steps testsuite to Hspec #4243

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Convert small-steps testsuite to Hspec #4243

merged 1 commit into from
Apr 9, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Apr 5, 2024 •
edited
Loading

Description

Resolves #4067

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky force-pushed the lucsanszky/convert-small-steps-test branch from fa49f76 to 982c688 Compare April 5, 2024 21:25
@Lucsanszky Lucsanszky marked this pull request as ready for review April 6, 2024 00:30
lehins
lehins approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thank you also for identifying and removing duplicate tests!

@lehins lehins force-pushed the lucsanszky/convert-small-steps-test branch from 982c688 to 7708af1 Compare April 8, 2024 18:32
@lehins lehins enabled auto-merge April 8, 2024 18:32
@lehins lehins force-pushed the lucsanszky/convert-small-steps-test branch from 7708af1 to 3cf47c8 Compare April 8, 2024 21:10
@lehins lehins merged commit 315e78d into master Apr 9, 2024
15 checks passed
@lehins lehins deleted the lucsanszky/convert-small-steps-test branch April 9, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@teodanciu teodanciu Awaiting requested review from teodanciu

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert small-steps-test to use hspec
2 participants
@Lucsanszky @lehins