Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imptests: CommitteeMinSize affects in-flight props #4244

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Imptests: CommitteeMinSize affects in-flight props #4244

merged 1 commit into from
Apr 16, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Apr 6, 2024 •
edited
Loading

Description

Resolves #4145

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested review from lehins and Soupstraw April 6, 2024 11:44
@aniketd aniketd force-pushed the aniketd/committeeminsize-affects-inflight-proposals branch 2 times, most recently from 8c60685 to 46c695f Compare April 8, 2024 14:17
lehins
lehins reviewed Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one of the tests can be improved, other than that it looks good.

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/committeeminsize-affects-inflight-proposals branch from 46c695f to 31eb7b8 Compare April 11, 2024 18:11
@aniketd aniketd requested a review from lehins April 11, 2024 18:12
lehins
lehins reviewed Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of minor suggestions

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs Outdated Show resolved Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/committeeminsize-affects-inflight-proposals branch from 31eb7b8 to 95c1a49 Compare April 15, 2024 11:05
@aniketd aniketd requested a review from lehins April 15, 2024 11:05
@lehins lehins enabled auto-merge April 15, 2024 17:49
lehins
lehins approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor adjustment.

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs Show resolved Hide resolved
@lehins lehins disabled auto-merge April 15, 2024 17:59
@lehins lehins enabled auto-merge (squash) April 15, 2024 17:59
@aniketd aniketd force-pushed the aniketd/committeeminsize-affects-inflight-proposals branch from 8b5c6a4 to 95c1a49 Compare April 16, 2024 07:05
@lehins lehins merged commit 8193b4a into master Apr 16, 2024
23 checks passed
@lehins lehins deleted the aniketd/committeeminsize-affects-inflight-proposals branch April 16, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imp test that changing ppCommitteeMinSize affects in flight proposals
2 participants
@aniketd @lehins