Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix withdrawals test data generation in EnactSpec #4248

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Apr 9, 2024

Description

Fixes a bug in how data for testing withdrawals is generated (not accounting for the case in which only one withdrawal is expected to exceed the treasury).

Solves #4240

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you for fixing it.
I had a feeling it had something to do with that function 😄

@lehins lehins enabled auto-merge April 9, 2024 14:58
@lehins lehins merged commit b31635f into master Apr 9, 2024
15 checks passed
@lehins lehins deleted the td/fix-treasury-test branch April 9, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants