Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some ToJSON instances needed by cardano-node #4250

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

neilmayhew
Copy link
Contributor

Description

These are currently orphan instances in cardano-node but belong in ledger.

Closes #3418

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@neilmayhew
Copy link
Contributor Author

@Jimbo4350 suggested I add some golden tests to make sure nothing breaks, so I'll do that next

@neilmayhew
Copy link
Contributor Author

The golden tests I've added are the same as the ones I added to node in IntersectMBO/cardano-node#5772. I'm assuming that the ones there will be discarded after being used to check the upgrade after integration. They pass with the instances that are currently in node, so they will verify that nothing has changed.

@neilmayhew neilmayhew marked this pull request as ready for review April 10, 2024 00:48
@neilmayhew neilmayhew requested a review from lehins April 10, 2024 00:48
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Rules/Utxos.hs Outdated Show resolved Hide resolved
@neilmayhew neilmayhew force-pushed the neilmayhew/3418-node-orphan-instances branch 2 times, most recently from 50ad708 to a44c8ab Compare April 10, 2024 15:27
@neilmayhew neilmayhew force-pushed the neilmayhew/3418-node-orphan-instances branch from a44c8ab to f4aecf6 Compare April 10, 2024 15:36
@neilmayhew neilmayhew merged commit 002b577 into master Apr 10, 2024
12 of 15 checks passed
@neilmayhew neilmayhew deleted the neilmayhew/3418-node-orphan-instances branch April 10, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ToJSON ledger instances from cardano-node
2 participants