Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate redeemerPointer and expose it in cardano-ledger-api #4259

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

ch1bo
Copy link
Contributor

@ch1bo ch1bo commented Apr 11, 2024

Description

User code may still rely on this as there is no other "off-the-shelf" conversion from an AsItem -> AsIx. As the alternative would be to implement this index lookup (e.g. for AlonzoSpending purpose) in user applications, we decide to rather keep it and expose it on the cardano-ledger-api.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@ch1bo ch1bo requested a review from lehins April 11, 2024 18:23
@ch1bo ch1bo force-pushed the undeprecate-redeemerPointer branch 2 times, most recently from 5173d0f to 3f8ef33 Compare April 11, 2024 18:27
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you

@lehins lehins enabled auto-merge April 11, 2024 18:33
User code may still rely on this as there is no other "off-the-shelf"
conversion from an AsItem -> AsIx. As the alternative would be to
implement this index lookup (e.g. for AlonzoSpending purpose) in user
applications, we decide to rather keep it and expose it on the
cardano-ledger-api.
@lehins lehins force-pushed the undeprecate-redeemerPointer branch from 3f8ef33 to d1252f1 Compare April 12, 2024 04:15
@ch1bo ch1bo mentioned this pull request Apr 12, 2024
4 tasks
@lehins lehins merged commit 8a99c2d into master Apr 12, 2024
14 of 16 checks passed
@lehins lehins deleted the undeprecate-redeemerPointer branch April 12, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants