Inline UTxO and UTxOW PredFailure for Conway
#4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
commented
Apr 15, 2024
|
Is there a ticket linked to this PR, for a little context? |
Sure! I've just updated the description and linked the issue. |
lehins
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Definition and translation of Predicate failures look good, except some InjectRuleFailure instances are missing. Definition of new rule, however, is not necessary.
Let me know if you can't figure it out or if something is preventing you from reusing UTXO rule from Babbage.
Lucsanszky
force-pushed
the
lucsanszky/stop-embedding-predfailures
branch
6 times, most recently
from
1d056ad to
5f3fe70
Compare
Lucsanszky
force-pushed
the
lucsanszky/stop-embedding-predfailures
branch
from
5f3fe70 to
6164768
Compare
Lucsanszky
force-pushed
the
lucsanszky/stop-embedding-predfailures
branch
from
940b320 to
5ef15df
Compare
Although GHC didn't warn about it, the constraint was superfluous.
Lucsanszky
force-pushed
the
lucsanszky/stop-embedding-predfailures
branch
from
5ef15df to
e114203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4170
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)