Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imptest to propose and enact unknown costmodels #4266

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Apr 15, 2024

Description

Resolves #4186

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested a review from lehins April 15, 2024 15:49
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but we can do a bit better

@aniketd aniketd force-pushed the aniketd/funny-costmodels branch from 95919f5 to c25c2ec Compare April 16, 2024 08:31
@aniketd aniketd requested review from lehins and teodanciu April 16, 2024 08:31
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aniketd aniketd force-pushed the aniketd/funny-costmodels branch from c25c2ec to 946762e Compare April 16, 2024 10:00
@aniketd aniketd enabled auto-merge (squash) April 16, 2024 10:00
@aniketd aniketd force-pushed the aniketd/funny-costmodels branch from 946762e to 0182634 Compare April 16, 2024 14:59
@lehins lehins force-pushed the aniketd/funny-costmodels branch from 0182634 to a5b12b3 Compare April 16, 2024 22:23
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aniketd aniketd merged commit 208819b into master Apr 17, 2024
15 checks passed
@aniketd aniketd deleted the aniketd/funny-costmodels branch April 17, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imp test proposals with funny CostModels
3 participants