Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation bug for sums of positive member spec #4269

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

MaximilianAlgehed
Copy link
Collaborator

Description

This unblocks @TimSheard

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@MaximilianAlgehed MaximilianAlgehed marked this pull request as ready for review April 16, 2024 09:59
@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-fix-map-sum-bug branch 2 times, most recently from 21485a6 to 8383fa2 Compare April 16, 2024 10:11
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Add a few comments where indicated.

libs/constrained-generators/src/Constrained/Base.hs Outdated Show resolved Hide resolved
libs/constrained-generators/src/Constrained/Base.hs Outdated Show resolved Hide resolved
@MaximilianAlgehed MaximilianAlgehed merged commit a11c2ca into master Apr 16, 2024
15 checks passed
@MaximilianAlgehed MaximilianAlgehed deleted the PR-fix-map-sum-bug branch April 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants