Restrict gov actions during bootstrap #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/bootstrap
branch
4 times, most recently
from
29bd4ed to
a6ee792
Compare
teodanciu
force-pushed
the
td/bootstrap
branch
3 times, most recently
from
ab65885 to
2018b99
Compare
teodanciu
commented
Apr 26, 2024
teodanciu
force-pushed
the
td/bootstrap
branch
6 times, most recently
from
52b5241 to
ed59299
Compare
teodanciu
force-pushed
the
td/bootstrap
branch
2 times, most recently
from
0e09f4d to
b37e3c6
Compare
lehins
approved these changes
Apr 29, 2024
lehins
reviewed
Apr 29, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/EnactSpec.hs
Outdated
Show resolved
Hide resolved
* separate tests that are relevant for bootstrap from those that are not * run the former only with protocol version 9, and all of them with version 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #3451
Implement bootstrap phase, which means, allowing only proposals of type: ParameterChange, HardForkInitiation and Info
and restricting DRep voting to proposals of type Info.
The biggest part of the PR is adjusting the tests, namely,
I have tried to maximize the number of test we can run for the bootstrap phase, so in some places i have replaced the type of proposal tested (eg: new constitution with parameter update).
Where this was too complicated (Eg: if drep voting was involved) or the tested proposal is not relevant for bootstrap by the nature of the proposal, I have separated the tests in two, and ran them with their appropriate protocol version.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)