Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constrained-generators: Fix bug in toPreds for maps + add additional tests #4279

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

MaximilianAlgehed
Copy link
Collaborator

Description

There was a silly bug in toPreds whereby the required elements of the domain would become the universe of the domain when you do toPreds. This resulted in maps being constrained to be empty under unfortunate circumstances.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@MaximilianAlgehed MaximilianAlgehed marked this pull request as ready for review April 19, 2024 12:26
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A one line change, a new rewrite rule, and some tests.
Looks good to me.

@MaximilianAlgehed MaximilianAlgehed merged commit 086c1aa into master Apr 19, 2024
15 checks passed
@MaximilianAlgehed MaximilianAlgehed deleted the PR-fix-map-toPred branch April 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants