Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plutus deps to 1.26 #4282

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Bump plutus deps to 1.26 #4282

merged 3 commits into from
Apr 24, 2024

Conversation

ana-pantilie
Copy link
Contributor

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. I approved too early.

Not all bounds have been updated and there are some changes in plutus that are causing test failures.
Needs investigation.

@ana-pantilie ana-pantilie force-pushed the ana/plutus-1.26 branch 2 times, most recently from db6ed79 to 327dfdf Compare April 22, 2024 18:41
@ana-pantilie
Copy link
Contributor Author

@lehins thanks, I fixed the issues. Please take another look when you have a moment!

@ana-pantilie ana-pantilie requested a review from lehins April 22, 2024 20:07
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lehins lehins enabled auto-merge April 23, 2024 23:28
@lehins lehins disabled auto-merge April 23, 2024 23:29
@lehins lehins enabled auto-merge (squash) April 23, 2024 23:30
Signed-off-by: Ana Pantilie <ana.pantilie95@gmail.com>
Signed-off-by: Ana Pantilie <ana.pantilie95@gmail.com>
Signed-off-by: Ana Pantilie <ana.pantilie95@gmail.com>
@lehins lehins merged commit b254589 into master Apr 24, 2024
33 checks passed
@lehins lehins deleted the ana/plutus-1.26 branch April 24, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants