Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constrained-generators: add new test to test suite #4283

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

MaximilianAlgehed
Copy link
Collaborator

Description

@TimSheard had a failure in this test on an old branch. It was fixed recently but I think it's none the less a nice minimal test for an old bug so we should keep it around to avoid regressions.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@MaximilianAlgehed MaximilianAlgehed changed the title Add nice new test to test suite constrained-generators: add new test to test suite Apr 19, 2024
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to have more tests, that test something that was missing.

@lehins lehins enabled auto-merge (squash) April 19, 2024 19:41
@lehins lehins merged commit 1e10022 into master Apr 19, 2024
15 checks passed
@lehins lehins deleted the PR-new-test branch April 19, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants