-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start Conway Imp tests with an initial committee and constitution #4285
Conversation
6a211ca
to
bfeaed7
Compare
c5a1b7b
to
3fbfdd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but committee initialization is a bit hacky and it seems that thresholds got relaxed for many tests
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
3fbfdd9
to
6a93d51
Compare
6a93d51
to
6e296c2
Compare
If you want to have another look @lehins when you can, thanks! |
6e296c2
to
289e09c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
289e09c
to
e174283
Compare
in order to reduce noise in tests
* set sensible values when initializing NewEpochState * remove duplicated modifications of the same parameters
e174283
to
1f80b22
Compare
Description
This PR is setting an initial committee and constitution for Conway (emulating the ones that will be defined in genesis).
For this, it was necessary to slightly modify the initialization of the NewEpochState in the Imp framework, to allow initialization actions before returning the state.
Tests were adjusted to only elect a committee if this action is actually meaningful to the test (relying on the initial committee otherwise).
Going through many tests was an opportunity to make some small improvements:
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)