Fix burning tokens predicate failure #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/fix-burning-tokens-predicate-failure
branch
2 times, most recently
from
d362b95 to
bf44e79
Compare
aniketd
reviewed
Apr 24, 2024
lehins
force-pushed
the
lehins/fix-burning-tokens-predicate-failure
branch
3 times, most recently
from
f0095b9 to
df47dc4
Compare
lehins
force-pushed
the
lehins/fix-burning-tokens-predicate-failure
branch
2 times, most recently
from
c7341ef to
eb1616a
Compare
Reorganize a bit how Imp tests are being invoked. This PR changes it in such a way that current era is responsible for calling imp tests from the previous era. This ensures that we are not gonna forget to run tests from some previous era in a new era.
`ValueNotConservedUTxO` cannot handle negative values, therefore we need to fix how this failure is being reported. Instead of reporting negative values for burned tokens in consumed, we change it to report it as positive in the produced. In order to implement above fix optional mapping, filtering and pruning for MultiAsset has been added as well.
lehins
force-pushed
the
lehins/fix-burning-tokens-predicate-failure
branch
from
eb1616a to
7d55419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem description
When transaction does not balance out in presence of burning the user submitting the transaction will get
DeserialiseFailure 56 "expected word"deserialization failure instead ofValueNotConservedUTxOpredicate failureFixes in this PR
ValueNotConservedUTxOcannot handle negative values, therefore we need to fix how this failure is being reported. Instead of reporting negative values for burned tokens in consumed, we change it to report it as positive in the produced.Ensure every predicate failure produced in the Imp test is also tested for serialization issues.
Reorganize a bit how Imp tests are being invoked. This PR changes it in such a way that current era is responsible for calling imp tests from the previous era. This ensures that we are not gonna forget to run tests from some previous era in a new era.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)