Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constrained-generators: Improve error messages and make the tree generator reasonably sized #4315

Merged
merged 4 commits into from
May 2, 2024

Conversation

MaximilianAlgehed
Copy link
Collaborator

Description

The tree generator used to produce trees of size at most 8000, now it defaults to 20 unless otherwise specified.

This also makes it so that the ErrorSpec we get from a bunch of operations actually carries the explain calls with it to
improve error logging.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

enourmous trees, and remove some old comments that aren't super relevant
any more.
@MaximilianAlgehed MaximilianAlgehed enabled auto-merge (squash) May 2, 2024 16:21
@MaximilianAlgehed MaximilianAlgehed merged commit ef72e18 into master May 2, 2024
118 checks passed
@MaximilianAlgehed MaximilianAlgehed deleted the PR-quality-of-life branch May 2, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants