Skip to content

[MOB-95] Don't switch to email as identifier after calling updateEmail with userId #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

[MOB-95] Don't switch to email as identifier after calling updateEmail with userId #87

merged 1 commit into from
Feb 13, 2019

Conversation

vbabenkoru
Copy link
Contributor

Follow-up fix!

tapashmajumder
tapashmajumder approved these changes Feb 13, 2019
View reviewed changes
Copy link

@tapashmajumder tapashmajumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vbabenkoru vbabenkoru merged commit 361585f into master Feb 13, 2019
@codecov
Copy link

codecov bot commented Feb 13, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9bfec2e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #87   +/-   ##
========================================
  Coverage          ?   69.2%           
========================================
  Files             ?      32           
  Lines             ?    1945           
  Branches          ?     230           
========================================
  Hits              ?    1346           
  Misses            ?     461           
  Partials          ?     138
Impacted Files Coverage Δ
...ain/java/com/iterable/iterableapi/IterableApi.java 63.14% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfec2e...64a0338. Read the comment docs.

@vbabenkoru vbabenkoru deleted the feature/MOB-95-support-userId-in-updateEmail branch April 1, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tapashmajumder tapashmajumder tapashmajumder approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbabenkoru @tapashmajumder