Skip to content

[MOB-95] Don't switch to email as identifier after calling updateEmail with userId #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2019
Merged

[MOB-95] Don't switch to email as identifier after calling updateEmail with userId #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,9 @@ public void updateEmail(final String newEmail, final IterableHelper.SuccessHandl
sendPostRequest(IterableConstants.ENDPOINT_UPDATE_EMAIL, requestJSON, new IterableHelper.SuccessHandler() {
@Override
public void onSuccess(JSONObject data) {
_email = newEmail;
if (_email != null) {
_email = newEmail;
}
storeEmailAndUserId();
if (successHandler != null) {
successHandler.onSuccess(data);
Expand Down
2 changes: 2 additions & 0 deletions iterableapi/src/test/java/com/iterable/iterableapi/IterableApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ public void testUpdateEmailWithUserId() throws Exception {
JSONObject requestJson = new JSONObject(updateEmailRequest.getBody().readUtf8());
assertEquals("testUserId", requestJson.getString(IterableConstants.KEY_CURRENT_USERID));
assertEquals("new@email.com", requestJson.getString(IterableConstants.KEY_NEW_EMAIL));
assertNull(IterableApi.getInstance().getEmail());
assertEquals("testUserId", IterableApi.getInstance().getUserId());
}

@Test
Expand Down