Make test data providers in multiple files static #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the test data providers in EmailTest, EnvTest, FilterTest, and TimerTest classes to be static. This approach allows these methods to be called without creating the test class instances, improving overall testing performance.
The test methods in EmailTest.php, EnvTest.php, and FilterTest.php have been repositioned for better organization. It is important to note that no significant changes were made to the functionalities of these methods; they were simply moved to a different part in their respective files for a more streamlined and logical order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the test data providers in EmailTest, EnvTest, FilterTest, and TimerTest classes to be static. This approach allows these methods to be called without creating the test class instances, improving overall testing performance.