Skip to content

Conversation

eolivelli
Copy link
Contributor

@eolivelli eolivelli commented Sep 28, 2020

Currently we only keep a reference to a parsed java.sql.Timestamp, but java.sql.Timestamp.valueOf uses local machine Timezone to parse the timestamp value, this is not good for statement rewriting if jSQLParser is running on a separate machine (like a server) with different JVM configuration

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 86.614% when pulling 39af0ec on eolivelli:fix/keep-raw-timestamp into 3f51651 on JSQLParser:master.

@wumpz wumpz merged commit 622f9ae into JSQLParser:master Oct 4, 2020
@eolivelli eolivelli deleted the fix/keep-raw-timestamp branch October 4, 2020 20:04
@eolivelli
Copy link
Contributor Author

Thanks for accepting my patch.
At HerdDB we hope can can see current master released soon 👍

@wumpz
Copy link
Member

wumpz commented Oct 4, 2020

I will try it, however, I have no much time at the moment.

@eolivelli
Copy link
Contributor Author

Thank you much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants