-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix issue in parsing TRY_CAST() function #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Prashant, thank you for the contribution and welcome to JSQLParser. Please consider the following minimum requirement for accepting the PR:
Right now, your query Do let me know if you will need any further assistance. |
Thanks for your review comments. I will work on those reviews and let you know once it's done. |
Hi @manticore-projects , Can you please review this PR again? I have changes the implementation as suggested by you. Please let me know if it still needs any changes. Best Regards, |
Thank you, it looks good to me and nicely done. |
Hi @wumpz , @manticore-projects , |
Greetings. Noted, we will see what we can do. @wumpz is author and owner of the software and only he can merge. I would be able to assist you with a Snapshot JAR if this helped anything. |
Sorry for being late with merging. You know, there is some other stuff to do. However, your PR looks good. |
I will deploy an actual snapshot during the next few hours. |
Hi @wumpz , Thanks a lot for merging this PR. |
MR request for issue #1390 Unable to parse snowflake's TRY_CAST() function