Add geometry distance operator #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wumpz
reviewed
Apr 2, 2022
| @@ -3110,6 +3110,8 @@ Expression RegularCondition() #RegularCondition: | |||
| | <OP_CONCAT> { result = new JsonOperator("||"); } | |||
| | "-" { result = new JsonOperator("-"); } | |||
| | "-#" { result = new JsonOperator("-#"); } | |||
| | <-> { result = new GeometryDistance("<->"); } | |||
There was a problem hiding this comment.
How did you test this line of code? It is definitely wrong. I corrected it.
| @@ -586,4 +587,8 @@ public void visit(IsDistinctExpression isDistinctExpression) { | |||
| isDistinctExpression.getRightExpression().accept(this); | |||
| } | |||
|
|
|||
| @Override | |||
| public void visit(GeometryDistance geometryDistance) { | |||
| visitOldOracleJoinBinaryExpression(geometryDistance, " <-> "); | |||
There was a problem hiding this comment.
This one deparses <#> to <->. I corrected it.
|
Could you provide an improvement to allow only <-> and <#> as operators. At the moment one could misuse |
|
Thanks for the fixes @wumpz. Is there an ETA on a release that'll include this? |
|
Not yet. Still, there are some issues there. Maybe I will speed up and release earlier. |
|
Now ... I delayed some open issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for PostGIS geometry distance operators: