Skip to content

Conversation

paxdei
Copy link

@paxdei paxdei commented Jan 12, 2016

Hi, this function is part of the ANSI SQL standard, though not widely supported

My changes are actually a copy/paste from the form bp2014n2/JSqlParser

@wumpz
Copy link
Member

wumpz commented Jan 12, 2016

Why are ther so many whitespace changes within your pull request? Please reduce your pull request only to the changes regarding this substring function.

@paxdei
Copy link
Author

paxdei commented Jan 31, 2016

Sorry, I had eclipse configured to auto-remove trailing spaces on save. I now have reverted most of these white-space changes

@wumpz
Copy link
Member

wumpz commented Feb 10, 2016

Sorry about my late answer.

So now I got some time to integrate some stuff into JSqlParser. Could you squash your commits into one and insert your issue id into the message? So it is easier to locate changes for specific issues. Thx for improving JSqlParser

paxdei and others added 24 commits August 16, 2016 23:33
# Conflicts:
#	src/main/java/net/sf/jsqlparser/expression/ExpressionVisitor.java
#	src/main/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapter.java
#	src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java
#	src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java
#	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
#	src/test/java/net/sf/jsqlparser/test/select/SelectTest.java
# Conflicts:
#	src/test/java/net/sf/jsqlparser/test/select/SelectTest.java
# Conflicts:
#	src/main/java/net/sf/jsqlparser/expression/ExpressionVisitor.java
#	src/main/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapter.java
#	src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java
#	src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java
#	src/test/java/net/sf/jsqlparser/test/select/SelectTest.java
# Conflicts:
#	src/main/java/net/sf/jsqlparser/expression/ExpressionVisitor.java
#	src/main/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapter.java
#	src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java
#	src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java
#	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
#	src/test/java/net/sf/jsqlparser/test/select/SelectTest.java
# Conflicts:
#	src/main/java/net/sf/jsqlparser/expression/ExpressionVisitor.java
#	src/main/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapter.java
#	src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java
#	src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java
#	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
#	src/test/java/net/sf/jsqlparser/test/select/SelectTest.java
# Conflicts:
#	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
#	src/test/java/net/sf/jsqlparser/test/select/SelectTest.java
# Conflicts:
#	src/test/java/net/sf/jsqlparser/test/select/SelectTest.java
@wumpz
Copy link
Member

wumpz commented Dec 30, 2018

already solved (different issue)

@wumpz wumpz closed this Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants