Skip to content

Add Upsert Grammer #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 11, 2017
Merged

Add Upsert Grammer #460

merged 15 commits into from
Jun 11, 2017

Conversation

messfish
Copy link
Contributor

@messfish messfish commented Jun 6, 2017

Greetings. Right now I am interestead in reading documents related to phoneix SQL so I want to see what I could contribute from it. It seems there is no "upsert" involved in the parser. So I write the
implementation of "Upsert" and several basic test cases.

@coveralls
Copy link

coveralls commented Jun 6, 2017

Coverage Status

Coverage decreased (-1.6%) to 84.871% when pulling b181025 on messfish:master into a55c4de on JSQLParser:master.

@wumpz
Copy link
Member

wumpz commented Jun 8, 2017

How do you explain this coverage descreasing by 1.6 percent? That is quite a bit.

@coveralls
Copy link

coveralls commented Jun 9, 2017

Coverage Status

Coverage decreased (-1.6%) to 84.871% when pulling 6daa831 on messfish:master into a55c4de on JSQLParser:master.

@coveralls
Copy link

coveralls commented Jun 9, 2017

Coverage Status

Coverage decreased (-0.8%) to 85.745% when pulling 6daa831 on messfish:master into a55c4de on JSQLParser:master.

@messfish
Copy link
Contributor Author

messfish commented Jun 9, 2017

How about this time? I think mainly because I failed to add test cases for the DeParser code.

@wumpz
Copy link
Member

wumpz commented Jun 9, 2017

Better instead of 1.6 now 0.8 percent. Dont you see all coveralls statistics within your pull request? I thought this is public.

@coveralls
Copy link

coveralls commented Jun 10, 2017

Coverage Status

Coverage decreased (-0.6%) to 85.915% when pulling 8b4f7b6 on messfish:master into a55c4de on JSQLParser:master.

@coveralls
Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage decreased (-0.6%) to 85.937% when pulling abc610e on messfish:master into a55c4de on JSQLParser:master.

@coveralls
Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage decreased (-0.5%) to 85.958% when pulling cf31a31 on messfish:master into a55c4de on JSQLParser:master.

@coveralls
Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage decreased (-0.5%) to 85.958% when pulling 1298bb6 on messfish:master into a55c4de on JSQLParser:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 85.954% when pulling 1298bb6 on messfish:master into a55c4de on JSQLParser:master.

@coveralls
Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage decreased (-0.4%) to 86.085% when pulling 1298bb6 on messfish:master into a55c4de on JSQLParser:master.

@coveralls
Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage decreased (-0.5%) to 85.958% when pulling 244afa6 on messfish:master into a55c4de on JSQLParser:master.

@coveralls
Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage increased (+0.1%) to 86.64% when pulling 244afa6 on messfish:master into a55c4de on JSQLParser:master.

@coveralls
Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage increased (+0.1%) to 86.64% when pulling 244afa6 on messfish:master into a55c4de on JSQLParser:master.

@coveralls
Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage increased (+0.2%) to 86.657% when pulling e4bc8ee on messfish:master into a55c4de on JSQLParser:master.

@messfish
Copy link
Contributor Author

All right Tobias, I finally get rid of the code coverage problem and everything works fine for me. Now can you look into my pull request?

@wumpz wumpz merged commit aaeb8df into JSQLParser:master Jun 11, 2017
@wumpz
Copy link
Member

wumpz commented Jun 12, 2017

Thx for the effort. I merged it already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants