Skip to content

fixes #320 #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2018
Merged

fixes #320 #576

merged 4 commits into from
Feb 1, 2018

Conversation

tmnsur
Copy link
Contributor

@tmnsur tmnsur commented Feb 1, 2018

Possible fix for #320

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.043% when pulling 91fcb4c on tmnsur:master into bf95154 on JSQLParser:master.

@coveralls
Copy link

coveralls commented Feb 1, 2018

Coverage Status

Coverage remained the same at 87.043% when pulling 9bdd4d2 on tmnsur:master into bf95154 on JSQLParser:master.

@wumpz
Copy link
Member

wumpz commented Feb 1, 2018

You need to test the deparsing. That should give you the original sqlTxt. meaning the deparser should rebuild the input syntax. You could use for the the tool funktion assertThatSqlCanBeParsedAndDeparsed.

@tmnsur
Copy link
Contributor Author

tmnsur commented Feb 1, 2018

it was already in 91fcb4c, between some more detailed checks. In last commit (9bdd4d2) i removed all lines but assertThatSqlCanBeParsedAndDeparsed.

@wumpz
Copy link
Member

wumpz commented Feb 1, 2018

Good. To merge I always use squash and merge from github. This would create a new summarizing commit from your commits. Therefore you would loose the connection to your branch. If thats ok for you, we could proceed. But if you are not, then provide a pull request with one commit.

@tmnsur
Copy link
Contributor Author

tmnsur commented Feb 1, 2018

That's ok, np.

@wumpz wumpz merged commit e645193 into JSQLParser:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants