Skip to content

Refactor to make the code more readable and testable #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2018
Merged

Refactor to make the code more readable and testable #629

merged 2 commits into from
Jun 20, 2018

Conversation

A4Vision
Copy link
Contributor

Refactor the class AnalyticExpression.
Extract the "partition by" and "order by" logics out of AnalyticExpression into two new classes, in order to make the code more testable and more readable.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 86.102% when pulling e3515d1 on A4Vision:extractclass/AnalyticExpression into aff6516 on JSQLParser:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 86.102% when pulling e3515d1 on A4Vision:extractclass/AnalyticExpression into aff6516 on JSQLParser:master.

@wumpz wumpz merged commit ffbf96e into JSQLParser:master Jun 20, 2018
@wumpz
Copy link
Member

wumpz commented Jun 20, 2018

Agreed ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@A4Vision @coveralls @wumpz