Skip to content

When calling toString on subjoin with joins, the result is not as expected #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2019
Merged

When calling toString on subjoin with joins, the result is not as expected #837

merged 3 commits into from
Aug 5, 2019

Conversation

tomershay
Copy link
Contributor

@tomershay tomershay commented Aug 5, 2019

For this query:
SELECT COUNT(DISTINCT tbl1.id) FROM (tbl1, tbl2, tbl3)
When parsing and deparsing, the output is:
SELECT COUNT(DISTINCT tbl1.id) FROM (tbl1 tbl2 tbl3)
Note the missing commas between the table names in the FROM clause.

This pull request fixes that issue.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 83.973% when pulling 47457ed on tomershay:subjoin_with_joins_issue into d9025e8 on JSQLParser:master.

@wumpz wumpz merged commit 333c4a9 into JSQLParser:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants