feat(install): add msi

[JanDeDobbeleer]

Prerequisites

• I have read and understood the contributing guide.
• The commit message follows the conventional commits guidelines.
• Tests for the changes have been added (for bug fixes / features).
• Docs have been added/updated (for bug fixes / features).

[heaths]

Pretty good overall, but I'd recommend defaulting to a per-user install, which is congruent with your current Windows install instructions as well as other platforms' install instructions e.g., using home-brew.

[JanDeDobbeleer]

@heaths the current installer is used by Winget/Scoop/Store who add the correct switches by default. Is that still a relevant change in that case? If there's an easy way to set the default, all in favor though.

[heaths]

@heaths the current installer is used by Winget/Scoop/Store who add the correct switches by default. Is that still a relevant change in that case? If there's an easy way to set the default, all in favor though.

I'd still make the default per-user. One advantage of using an MSI - as long as you keep the same UpgradeCode and change the ProductCode and ProductVersion (any of the first 3 fields; the 4th is ignored) with each revision - no matter how a user gets it, it'll always be installed or upgraded. Don't depend on a single chained or package manager. Someone could install it via widget but upgrade it later via scoop. And different package managers require different managers or even default per-user or per-machine contexts differently. Let the MSI dictate the defaults.

[heaths]

...though, more likely is someone install it via scoop or chocolatey and upgrade it via winget. The former two keep a manifest of what they installed and can upgrade, while winget will discover any MSI installed (uses the MSI APIs) and offer an upgrade based on its manifest if one is available regardless of how it's installed. That's why I've worked with partners on using MSI as the installer package rather than package manager-specific manifests: it's easy to get duplicative installs that way, but having a single registered package that dictates its default behavior works out regardless of how it's installed.

[JanDeDobbeleer]

@heaths I think I got them all 😅