Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: "This package is based on" notice replaces create-typescript-app with --repository #750

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 2, 2023 · 1 comment · Fixed by #844
Closed
3 tasks done

🐛 Bug: "This package is based on" notice replaces create-typescript-app with --repository #750

JoshuaKGoldberg opened this issue Sep 2, 2023 · 1 comment · Fixed by #844
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Running any setup script on a repository should put the following notice on the bottom of the README.md:

<!-- You can remove this notice if you don't want it 🙂 no worries! -->

> 💙 This package is based on [@JoshuaKGoldberg](https://github.com/JoshuaKGoldberg)'s [template-typescript-node-package](https://github.com/JoshuaKGoldberg/template-typescript-node-package).

Actual

<!-- You can remove this notice if you don't want it 🙂 no worries! -->

> 💙 This package is based on [@JoshuaKGoldberg](https://github.com/JoshuaKGoldberg)'s [all-contributors-auto-action](https://github.com/JoshuaKGoldberg/all-contributors-auto-action).

Lol. The find-and-replace script that switches from the template title to the provided repository title (--repository) must be catching this.

Additional Info

Discovered on https://github.com/JoshuaKGoldberg/all-contributors-auto-action/tree/1ce7a4d2df5fd69765b7d407654847fde9e30340:

git clone https://github.com/JoshuaKGoldberg/all-contributors-auto-action
cd all-contributors-auto-action
git checkout 1ce7a4d2df5fd69765b7d407654847fde9e30340
pnpm i
npx create-typescript-app --base everything --mode migrate
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Sep 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 19, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Sep 19, 2023
@JoshuaKGoldberg
fix: undo overwriting of README.md attribution in updateLocalFiles (#844
858847a 
)

## PR Checklist

- [x] Addresses an existing open issue: fixes #750
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds a manual find-and-replace back in `updateLocalFiles`.
@github-actions
Copy link

🎉 This is included in version v1.29.45 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Post-Rename Migration
1 participant
@JoshuaKGoldberg