Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undo overwriting of README.md attribution in updateLocalFiles #844

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Adds a manual find-and-replace back in updateLocalFiles.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #844 (f98bb62) into main (09dbd39) will increase coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
+ Coverage   92.15%   92.16%   +0.01%     
==========================================
  Files          84       84              
  Lines        4221     4227       +6     
  Branches      262      262              
==========================================
+ Hits         3890     3896       +6     
  Misses        331      331              
Flag Coverage Δ
create 71.83% <0.00%> (-0.11%) ⬇️
initialize 34.69% <100.00%> (+0.09%) ⬆️
migrate 73.29% <100.00%> (+0.03%) ⬆️
unit 52.56% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/updateLocalFiles.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 858847a into main Sep 19, 2023
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix-update-local-files-overwrite-attribution branch September 19, 2023 19:57
@github-actions
Copy link

🎉 This is included in version v1.29.45 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: "This package is based on" notice replaces create-typescript-app with --repository
1 participant