Skip to content

Conversation

@baggepinnen
Copy link
Member

Julia v1.8 brought with it a massive increase in compile times :(
Unfortunately, the tests now take roughly 3x longer to run on my local machine compared to for julia v1.7.3
The regression has been reported, but until then, I try to just increase the timeout threshold

Julia v1.8 brought with it a massive increase in compile times :(
Unfortunately, the tests now take roughly 3x longer to run on my local machine compared to for julia v1.7.3
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 9/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.034 Reference New
❌ 0.059 Reference New
✔️ 0.0 Reference New
✔️ 0.01 Reference New

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #726 (234645c) into master (a60f302) will increase coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   91.46%   91.98%   +0.52%     
==========================================
  Files          37       37              
  Lines        3877     3992     +115     
==========================================
+ Hits         3546     3672     +126     
+ Misses        331      320      -11     
Impacted Files Coverage Δ
src/freqresp.jl 93.75% <0.00%> (-1.04%) ⬇️
src/types/staticsystems.jl 93.69% <0.00%> (-0.81%) ⬇️
src/hammerstein_weiner.jl 92.74% <0.00%> (-0.37%) ⬇️
src/matrix_comps.jl 93.10% <0.00%> (-0.16%) ⬇️
src/analysis.jl 96.22% <0.00%> (-0.10%) ⬇️
src/connections.jl 92.70% <0.00%> (ø)
src/simplification.jl 100.00% <0.00%> (ø)
src/types/conversion.jl 98.57% <0.00%> (+0.04%) ⬆️
src/pid_design.jl 93.24% <0.00%> (+0.06%) ⬆️
src/discrete.jl 87.94% <0.00%> (+0.08%) ⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@baggepinnen baggepinnen merged commit 2407165 into master Aug 22, 2022
@baggepinnen baggepinnen deleted the timeout branch August 22, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants