Support anonymous functions #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 61.57% // Head: 95.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
===========================================
+ Coverage 61.57% 95.25% +33.68%
===========================================
Files 3 3
Lines 229 232 +3
===========================================
+ Hits 141 221 +80
+ Misses 88 11 -77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
timholy
added a commit
that referenced
this pull request
Feb 25, 2023
Keyword dispatch methods went away in Julia 1.9, replaced by the generic `kwcall`. In #102 I disabled the corresponding test. That was misguided because we still want to be able to recover the source definition, regardless of the details of the underlying implementation.
Merged
timholy
added a commit
that referenced
this pull request
Feb 25, 2023
Keyword dispatch methods went away in Julia 1.9, replaced by the generic `kwcall`. In #102 I disabled the corresponding test. That was misguided because we still want to be able to recover the source definition, regardless of the details of the underlying implementation.
timholy
added a commit
that referenced
this pull request
Mar 19, 2023
While working on TypedSyntax.jl it became apparent that CodeTracking sometimes returns spurious results. At least some of these arise from the recent support of anonymous functions, #102, which might in retrospect have been ill-considered. Rather than back that change out, this adopts a different resolution: validate the hits more carefully. The primary mechanism introduced here is to match not just the function name, but also the argument names. This can work even for anonymous functions, so we do not need to drop support for them. This also adds quite a few new tests. These additions would have passed before, but they proved valuable to ensure that the new argname-matching works sufficiently well. On TypedSyntax's "exhaustive.jl" test, this brings the number of failed cases (specifically, the `badmis`) from either 460 or 94 (depending on whether you include a few fixes in TypedSyntax) to just 2.
4 tasks
timholy
added a commit
that referenced
this pull request
Mar 31, 2023
While working on TypedSyntax.jl it became apparent that CodeTracking sometimes returns spurious results. At least some of these arise from the recent support of anonymous functions, #102, which might in retrospect have been ill-considered. Rather than back that change out, this adopts a different resolution: validate the hits more carefully. The primary mechanism introduced here is to match not just the function name, but also the argument names. This can work even for anonymous functions, so we do not need to drop support for them. This also adds quite a few new tests. These additions would have passed before, but they proved valuable to ensure that the new argname-matching works sufficiently well. On TypedSyntax's "exhaustive.jl" test, this brings the number of failed cases (specifically, the `badmis`) from either 460 or 94 (depending on whether you include a few fixes in TypedSyntax) to just 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80