Support Core.kwcall
#105
Merged
Support Core.kwcall
#105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keyword dispatch methods went away in Julia 1.9, replaced by the generic `kwcall`. In #102 I disabled the corresponding test. That was misguided because we still want to be able to recover the source definition, regardless of the details of the underlying implementation.
Codecov ReportBase: 95.25% // Head: 91.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 95.25% 91.39% -3.87%
==========================================
Files 3 3
Lines 232 244 +12
==========================================
+ Hits 221 223 +2
- Misses 11 21 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I don't understand why it's reporting no coverage for this code; it clearly is covered locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword dispatch methods went away in Julia 1.9, replaced by the
generic
kwcall. In #102 I disabled the corresponding test.That was misguided because we still want to be able to recover the
source definition, regardless of the details of the underlying
implementation.