-
-
Notifications
You must be signed in to change notification settings - Fork 235
Minor cleanup #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor cleanup #103
Conversation
|
It seems like we should try to be consistent with how we shorten macro names. Some ideas: # Option A
@param t σ
@var x(t) y(t)
@deriv D'~t# Option B
@parameter t σ
@variable x(t) y(t)
@derivative D'~t D''~tWe could also pluralize. Thoughts? @ChrisRackauckas @dpsanders |
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 92.02% 93.29% +1.26%
==========================================
Files 11 11
Lines 326 328 +2
==========================================
+ Hits 300 306 +6
+ Misses 26 22 -4
Continue to review full report at Codecov.
|
|
I think Option A is fine, but I think @dpsanders likes the full names? |
|
Whoa, this has a version-based bug - works on 1.1/nightly, but not on 1.0. |
|
The more I look at the options, I like the full names (Option B) - since these lines will only be typed a few times at the beginning of each model, it seems reasonable to make the names slightly more verbose/clear. I also think pluralizing will help with this goal. @parameters t σ
@variables x(t) y(t)
@derivatives D'~t D''~t@ChrisRackauckas Am I good to change this? |
|
Yeah that looks good. |
|
Update: the reason 1.1 works (while 1.0 fails) seems to be due to JuliaLang/julia#29668. This does beg the question of whether or not we should have comparison functions return non-booleans (outside of an explicit context), though. |
|
What booleans would they return? |
Closes #99, closes #100, closes #101.