Include Jacobian in generated ODEFunction #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/systems/diffeqs/diffeqsystem.jl
Outdated
| function DiffEqBase.ODEFunction(sys::ODESystem, dvs, ps; version::FunctionVersion = ArrayFunction) | ||
| expr = generate_function(sys, dvs, ps; version = version) | ||
| expr = eval(generate_function(sys, dvs, ps; version = version)) | ||
| jac_expr = isempty(sys.jac[]) ? nothing : eval(generate_jacobian(sys)) |
Contributor
There was a problem hiding this comment.
This means that unless the Jacobian has already been computed, it won't be included. Is that the desired behavior?
(Note that jac_expr = eval(generate_jacobian(sys)) would use the cached version if one exists, computing it otherwise.)
Member
Author
There was a problem hiding this comment.
Yes, this gives an opt-in mechanism: call calculate_jacobian if you want it.
Contributor
There was a problem hiding this comment.
That seems like a rather strange/unintuitive way of opting in (which also makes the fact that we currently cache Jacobians user-facing)... couldn't we just have a kwarg for jac::Bool = false?
Member
Author
There was a problem hiding this comment.
Yes, we can do it with a bool as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.