Skip to content

Conversation

@YingboMa
Copy link
Member

@YingboMa YingboMa commented Jul 6, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jul 6, 2019

Codecov Report

Merging #146 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #146      +/-   ##
=========================================
+ Coverage   94.26%   94.4%   +0.13%     
=========================================
  Files          11      11              
  Lines         366     375       +9     
=========================================
+ Hits          345     354       +9     
  Misses         21      21
Impacted Files Coverage Δ
src/ModelingToolkit.jl 75% <ø> (ø) ⬆️
src/utils.jl 93.22% <100%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aabee57...729cadc. Read the comment docs.


return vars
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go with the ODESystem stuff.

@HarrisonGrodin
Copy link
Contributor

HarrisonGrodin commented Jul 6, 2019

Can we name this differently, please? Haha. Maybe symbolic or model?

@ChrisRackauckas
Copy link
Member

symbolify? symbolicitizationifyification

@ChrisRackauckas
Copy link
Member

ehh I actually like the name, since most others will clash with libraries like SymPy and whatnot, so we might as well say how we are symbolicing it.

@ChrisRackauckas ChrisRackauckas merged commit 93fe6bd into SciML:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants