Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 1.9 fixed - Update installation.md #500

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

PallHaraldsson
Copy link
Contributor

No description provided.

@PallHaraldsson
Copy link
Contributor Author

It's unclear to be it was stated 1.6 was fixed. I don't think that LTS version is. I wouldn't bother mentioning it, feel free. I believe 1.10 will be LTS and probably soon.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (19117e2) 75.16% compared to head (96dbd44) 75.16%.

❗ Current head 96dbd44 differs from pull request most recent head f6a3a78. Consider uploading reports for the commit f6a3a78 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   75.16%   75.16%           
=======================================
  Files          25       25           
  Lines        1623     1623           
=======================================
  Hits         1220     1220           
  Misses        403      403           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/src/installation.md Outdated Show resolved Hide resolved
[skip ci]

Co-authored-by: Phillip Alday <palday@users.noreply.github.com>
@PallHaraldsson
Copy link
Contributor Author

bump

Copy link
Collaborator

@palday palday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this. Clearly there has been additional work in 1.9, but I also remember this mostly being a problem with Julia <= 1.5 -- I don't recall ever encountering this on 1.6+. I guess though the official close date of the linked issue was late 2022, so 1.9 is a reasonable cutoff point.

@palday palday merged commit ba1ea5c into JuliaInterop:master Sep 14, 2023
@PallHaraldsson PallHaraldsson deleted the patch-3 branch September 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants