Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Julia compat #530

Merged
merged 1 commit into from
Jun 6, 2024
Merged

bump Julia compat #530

merged 1 commit into from
Jun 6, 2024

Conversation

palday
Copy link
Collaborator

@palday palday commented Jun 4, 2024

There's nothing in RCall itself that's incompatible with Julia 1.0, but the dependencies for testing are not resolvable on 1.0 and we haven't tested on 1.0 in a while.

There's nothing in RCall itself that's incompatible with Julia 1.0, but the dependencies for testing are not resolvable on 1.0 and we haven't tested on 1.0 in a while.
@palday palday requested a review from ararslan June 4, 2024 01:59
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.49%. Comparing base (44a3089) to head (dcac933).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files          26       26           
  Lines        1684     1684           
=======================================
  Hits         1305     1305           
  Misses        379      379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palday palday merged commit 62ae259 into master Jun 6, 2024
11 of 15 checks passed
@palday palday deleted the pa/julia_compat branch June 6, 2024 16:16
@ViralBShah
Copy link
Contributor

ViralBShah commented Jun 26, 2024

Should we tag a new release v0.15 to go with this? Will address #529 (not by fixing the issue, but a new lower bound becomes clear).

@palday
Copy link
Collaborator Author

palday commented Jun 26, 2024

@ViralBShah I think the real fix to #529 would be updating compat in General to reflect when the dependencies are actually resolvable. Releasing a new version with a bumped compat bound will just lead to Pkg trying the older versions and still failing in the same way. I haven't had time to actually bisect and figure out at what point we can no longer resolve our dependencies -- I'll try to do that in the next few days.

@palday palday mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants