Skip to content

Clean julia 0.4 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
EQt wants to merge 37 commits into from
Closed

Clean julia 0.4 #52

EQt wants to merge 37 commits into from

Conversation

@EQt
Copy link
Contributor

@EQt EQt commented Mar 3, 2016

No description provided.

Ben Moran and others added 17 commits December 10, 2015 14:30
Changes for Julia 0.4; print error stracktraces within Julia; rename …
f2ad08b 
…call->_call to avoid collision with Julia
Fix tests
8884aad
@benmoran
Use jl_init instead of julia_init
86d1f8d
@benmoran
Allow jl_init_path to differ from jl_runtime_path. First attempt at a…
cc0fa10 
…ppveyor.yml
@benmoran
Use JULIA_EXE environment variable with unit tests
e5ffae4
@benmoran
Remove obsolete find_sysimg
b0b2179
@benmoran
Update JULIA_EXE in appveyor.yml
95840b5
@benmoran
Use python from path in appveyor.yml
60a56fe
@benmoran
appveyor correction
a1cdce7
@benmoran
Init variable check for bool(s) instead of s is None, since python3 b…
3818616 
…ehaviour differs
@benmoran
appveyor tweak
fc8a386
@benmoran
Python 3 string types
d8c5353
@benmoran
Python 3 bytestrings, test removing Pkg.init from .travis.yml
ba105d9
@EQt
initialize JULIA_INIT_DIR with JULIA_HOME
0d175c8 
see http://docs.julialang.org/en/release-0.4/manual/embedding#example
@EQt
using ... in julia
4bb5956
@EQt
skip undefined names
5947b6e
@EQt
there is no help(...) function in Julia, anymore
11f5d71
@mmagnuski
Copy link

mmagnuski commented Mar 4, 2016

adding appveyor would be nice to see if checks pass on windows too

@tkelman
Copy link

tkelman commented Mar 6, 2016

We just need to have a volunteer to run it on their account. I can set up the webhook once a url is provided.

@EQt
Copy link
Contributor Author

EQt commented Mar 8, 2016

I just setup https://ci.appveyor.com/project/EQt/pyjulia
But I have not used AppVeyor before. Does anyone know how to configure it?

@tkelman
Copy link

tkelman commented Mar 8, 2016

Can you go to the settings, and copy-paste the "webhook url" here? Then I'll enable the webhook from the github side here and we can try triggering a build, see how it goes.

@EQt
Copy link
Contributor Author

EQt commented Mar 9, 2016

If I understood it right, the webhook url is
https://ci.appveyor.com/api/github/webhook?id=vu38lh59skrtal03

In the latest Build, the tests just run infinitely long... Don't know why.

EQt added 2 commits March 15, 2016 10:45
@EQt
actually use the libjulia of the runtime
aacb4dd
@EQt
Make appveyor work, again.
a9d4f67 
Print a lot of debugging messages.
Create a minimal executable to interacte with libjulia to find a bug more easily.
@EQt EQt force-pushed the clean-julia-0.4 branch from 409a789 to a9d4f67 Compare March 24, 2016 15:36
@EQt EQt force-pushed the clean-julia-0.4 branch from 0f29587 to 0cad73a Compare March 25, 2016 11:25
@meggart
Copy link

meggart commented May 9, 2016

What is the current status of this PR? Master is broken for me and this PR seems to fix it, can this be merged?

@mmagnuski
Copy link

mmagnuski commented May 9, 2016

+1 for merge, but @jakebolewski seems to be MIA.
Maybe @tkelman can merge?
@EQt @benmoran

@tkelman
Copy link

tkelman commented May 9, 2016

The history here needs cleaning up, and CI did not run.

@mmagnuski
Copy link

mmagnuski commented May 10, 2016

Actually, appveyor did run, but didn't run any tests.
It seems to fail to run tests because it is using python -m unittest discover from C:\MinGW\bin while pyjulia resides in C:\projects\pyjulia. So it is missing only a cd C:\projects\pyjulia.
I don't know why Travis didn't run. Can you restart Travis for this PR @tkelman ?
@EQt @benmoran

@tkelman tkelman closed this May 11, 2016
@tkelman tkelman reopened this May 11, 2016
tkelman
tkelman reviewed May 11, 2016
View reviewed changes
.travis.yml
- clang
branches:
only:
- clean-julia-0.4
Copy link

@tkelman tkelman May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this

@Keno
Copy link
Contributor

Keno commented Jul 18, 2016

Relevant parts were included in #54.

@Keno Keno closed this Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@EQt @mmagnuski @tkelman @meggart @Keno @benmoran