Hot fix for #479 #480
Merged
Hot fix for #479 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This symptomatically fixes the issues described in #479. I am not sufficiently familiar with meta programming and macro hygiene to tell if this is should be fixed in MacroTools instead though. Maybe some of the MacroTools.jl maintainers (such as @cstjean) can chime in here? xref: FluxML/MacroTools.jl#30 |
lassepe
force-pushed
the
fix/missing_macro_tools
branch
from
72f0e65
to
7b177a7
Compare
|
Awesome, thanks for the fix - and the test! Will make a new release shortly. |
|
Yeah, I see it as a MacroTools bug, as posted in FluxML/MacroTools.jl#30. I would be happy to merge a MacroTools PR that fixes that. It's probably sufficient to turn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #479