#7 - Initial implementation #10

mforets · 2018-04-24T01:17:54Z

Closes #7.

make option raw_dict=true
~~[ ] make option raw_dict=false (default)~~
~~[ ] add functions to docs~~

EDIT: i'm readdressing this issue:

output the hybrid automaton by default without any assumption on the system type
add unit tests
add functions to docs

this leaves for the next issue to transform the information of the hybrid automaton into a given system type, that is (A, B, X, U), where X, U have to be transformed from expressions to some LazySet representation.

mforets · 2018-04-27T18:18:51Z

From my side this branch is ready to be merged.

schillic

I only had a rough look.

schillic · 2018-04-27T19:59:47Z

docs/src/examples/examples.md

+
+`spaceex -g name.cfg -m name.xml --output-system-file new_name.xml`
+
+However, note that the flattening process change the original model and may induce parsing errors. The parsing errors only appear when the constructed model is visualized/analyzed with the Model Editor or/and the Web Interface. There are no parsing errors with the source code/executable SpaceEx. A list of identified parsing problems follows below.


schillic · 2018-04-27T20:00:56Z

docs/src/examples/examples.md

+However, note that the flattening process change the original model and may induce parsing errors. The parsing errors only appear when the constructed model is visualized/analyzed with the Model Editor or/and the Web Interface. There are no parsing errors with the source code/executable SpaceEx. A list of identified parsing problems follows below.
+
+1. Special symbols, e.g. ~, _ in the variable and location names
+2. Characters and symbols in the notes


What is the difference between characters and symbols?

Probably the best thing is to suggest that users employ only Latin alphabet and no special characters.

To answer your question, from my standpoint, symbols correspond to mathematical operations (,},/,*,+,_ and characters to non-latin characters, e.g. Greek or Russian letters

schillic · 2018-04-27T20:01:16Z

docs/src/examples/examples.md

+
+1. Special symbols, e.g. ~, _ in the variable and location names
+2. Characters and symbols in the notes
+3. Nondeterministic flows, e.g. x'==x+w, where 0<w1<0.1 (see bball_nondet)


"w" or "w1"?

correct! w or w1 should be kept

schillic · 2018-04-27T20:03:12Z

docs/src/index.md

-3. Nondeterministic flows, e.g. x'==x+w, where 0<w1<0.1 (see bball_nondet)
-4. Nondeterministic resets, e.g. v' == -0.75*v+w2 (see bball_nondet)
-5. Naming issues, e.g. default variable name is component.subcomponent.variable
+A visual model editor is available for download in the [SpaceEx website](http://spaceex.imag.fr/download-6).


in → on ?

schillic · 2018-04-27T20:05:57Z

src/io.jl

+### Output
+
+Hybrid system that corresponds to the given SX model and the given assumptions
+on the system type. If `raw_dict=true`; otherwise, a dictionary with the Julia


If raw_dict=true

Is there something missing?

schillic · 2018-04-27T20:32:36Z

src/parse.jl

+### Output
+
+The tuple `(q, r, G, A)` where `q` and `r` are the source mode and target mode
+respectively for this location, `G` is the list of guards for this location,


location → transition (2x)

schillic · 2018-04-27T20:33:06Z

src/parse.jl

+
+The tuple `(q, r, G, A)` where `q` and `r` are the source mode and target mode
+respectively for this location, `G` is the list of guards for this location,
+and `A` is the list of assignments. Both objects are vectors of


Both objects → Both G and A ?

schillic · 2018-04-27T20:34:53Z

src/parse.jl

+
+### Notes
+
+It is assumed that the "source" and "target" fields can be cast to integers.


This sounds strict. Is this reasonable?
Otherwise you could store the transitions in a temporary data structure and obtain the location IDs later from a dictionary "location name → location ID".

This is given by the format, those id's are assigned automatically (for locations, transitions, etc). I don't remember if there is a way of editing these fields in the model editor.

schillic · 2018-04-27T20:36:48Z

test/runtests.jl

+end
+
+#=
+@testset "Circle" begin


What about this one?

schillic · 2018-04-27T20:39:07Z

src/parse.jl

+
+Consists of the following steps (in the given order):
+
+- split the string with the `&` key


Do you want to allow parentheses? Since the formulas are purely conjunctive, they could just be ignored.

good point. as a by-product of parse, parentheses are ignored:

julia> parse_sxmath("(x == 0) & ((v <= 0))") 2-element Array{Expr,1}: :(x = 0) :(v <= 0)

note that & is the same as && for SpaceEx

note that & is the same as && for SpaceEx

Thanks. I've updated the function parse_sxmath accordingly.

schillic · 2018-04-27T20:45:37Z

src/io.jl

+- `invariants`
+- `flows`
+- `resetmaps`
+- `switchings`


What is the difference between resetmaps and switchings? Is there a reason to have both?

the association that i did (naively, subject to discussion) is:

resetmaps field in HybridSystems <-> assignments in SX

switchings field in HybridSystems <-> guards in SX

Ah ok, this is coming from HybridSystems. Makes sense.

The guards (i.e. the sets in which the states need to be to do the switching should be in the resetmaps) as the constraint set X of Systems.jl. switchings is meant to be the nature of the switching (e.g. controlled switching vs autonomous switching of Section 1.1.3 of Liberzon "Switching in Systems and Control")
EDIT I have added documentation for it in the HybridSystems doc

Thanks for the hints, this helped a lot.

In the examples added up to now, the switchings are autonomous since they are defined by hypersurfaces for the states.

For the resetmaps, we take discrete constrained systems, whose state constraints are given by guards in SX (or eventually, input constraints), and the coefficient matrices are read from the assignments in SX.

That seems perfect :)

mforets · 2018-05-06T13:06:15Z

Thanks to all of you for the feedback.

mforets added 7 commits April 23, 2018 12:48

update REQUIRE

b6ff4ee

add io, parse, symbolic

501c95d

update io

d26b22a

Merge branch 'master' into mforets/7

8f186a7

add DataStructures to REQUIRE

89941d5

update branchg

15ab762

update readsxmodel

5e14a78

mforets self-assigned this Apr 26, 2018

mforets added 5 commits April 27, 2018 12:17

add 3 unit tests

fdbeecb

update tests

e9170bc

update docs

5306e01

add examples.md

57cb6da

start Examples section

d36ee41

mforets changed the title ~~[WIP] #7 - Initial implementation~~ #7 - Initial implementation Apr 27, 2018

schillic reviewed Apr 27, 2018

View reviewed changes

mforets added 5 commits April 28, 2018 16:03

add Circle test

4ca1a27

more cases in parse sxmath

e5a99f1

update branch

3c19bba

update implementation

f3446a9

fix docstrings in parse

3f29447

mforets merged commit f01e1f4 into master May 6, 2018

mforets deleted the mforets/7 branch May 6, 2018 13:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#7 - Initial implementation #10

#7 - Initial implementation #10

mforets commented Apr 24, 2018 •

edited

Loading

mforets commented Apr 27, 2018

schillic left a comment

schillic Apr 27, 2018

schillic Apr 27, 2018

nikos-kekatos May 1, 2018 •

edited

Loading

schillic Apr 27, 2018

nikos-kekatos May 1, 2018

schillic Apr 27, 2018

nikos-kekatos May 1, 2018

schillic Apr 27, 2018

schillic Apr 27, 2018

schillic Apr 27, 2018

schillic Apr 27, 2018

mforets May 6, 2018 •

edited

Loading

schillic Apr 27, 2018

mforets Apr 28, 2018

schillic Apr 27, 2018

mforets May 1, 2018

nikos-kekatos May 1, 2018

mforets May 6, 2018

schillic Apr 27, 2018

mforets Apr 28, 2018

schillic Apr 28, 2018

blegat Apr 28, 2018 •

edited

Loading

mforets May 1, 2018

blegat May 6, 2018

mforets commented May 6, 2018


		`spaceex -g name.cfg -m name.xml --output-system-file new_name.xml`

		However, note that the flattening process change the original model and may induce parsing errors. The parsing errors only appear when the constructed model is visualized/analyzed with the Model Editor or/and the Web Interface. There are no parsing errors with the source code/executable SpaceEx. A list of identified parsing problems follows below.


		### Notes

		It is assumed that the "source" and "target" fields can be cast to integers.


		Consists of the following steps (in the given order):

		- split the string with the `&` key

#7 - Initial implementation #10

#7 - Initial implementation #10

Conversation

mforets commented Apr 24, 2018 • edited Loading

mforets commented Apr 27, 2018

schillic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikos-kekatos May 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mforets May 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blegat Apr 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mforets commented May 6, 2018

mforets commented Apr 24, 2018 •

edited

Loading

nikos-kekatos May 1, 2018 •

edited

Loading

mforets May 6, 2018 •

edited

Loading

blegat Apr 28, 2018 •

edited

Loading