Repository navigation
v5.19.0
Added
- A design review runs by itself when a wave changes UI files, and
/closewarns when the repo could render the change and no review covers it (#1452). On by default and advisory. The close gate is warn-only; nothing switches it automatically. Switch it off without a commit viaSO_DESIGN_REVIEW=offorowner.yamldesign-review.enabled: false, committed viadesign-review.enabled: false. Every setting resolves env > owner.yaml > committed > default.- Trigger: after an Impl-Core or Impl-Polish wave,
scripts/design-review.mjs detectclassifies the wave's files withclassifyUiPaths()(scripts/lib/ui-touch.mjs).- Application UI source counts: components, pages, app styles, in-app message catalogues.
- Never counted: tests, stories, fixtures, eval pages, tool output, docs, research, scaffolds, exported designs, test setup, mocks, generated code (
__generated__/,gql/,*.gen.*,*.generated.*; a plaingenerated/directory counts), video compositions, everything underpages/api/andapp/api/(.tsxincluded),app/**/route.ts, and logic files inapi/andserver/directories. - Exceptions that count:
test/andtests/route directories underapp/,pages/orroutes/; e-mail directories insideapp/,pages/,routes/,components/orfeatures/; components and pages in any other directory namedapi,serverormail. - The defaults are heuristics;
design-review.includereplaces the UI globs,design-review.excludeadds exclusions, and the default exclusions always win. - Measured with
git ls-filesover six repos: vault 288 → 0 matches, browser-kit 77 → 0, EventDrop.at 974 → 857 (its app).
- Review: wave-loop-review.md step 5b captures the rendered result at 1440 and 390 with the test-runner driver. It reviews with agentic-designer's
designer critique(on PATH or atdesign-review.designer, adapterscripts/lib/designer-critique.mjs), else withux-evaluator.- Findings and verdicts are recorded and shown only (
design-review.act-on-verdicts: false, both reviewers). Reason:designer critiquehad 23 of 37 findings wrong in its first production run (agentic-designer#85), andux-evaluatorrubric-v2 has no measured precision on real pages. - The page's value sentence reaches only
--imagepage-top shots, never a--section-image. - Page-top shots get
--role first-view, section shots--role section. Adesignerthat rejects the flag (exit 2,INVALID_ARGUMENTSnaming--role) is rerun once without it within the same per-shot time limit, and the output carries arole_fallbackwarning. - At most two rounds per surface and session.
- Findings and verdicts are recorded and shown only (
- Close: session-end Phase 2.7 runs
design-review.mjs check.- With
design-review.close-gate: warn(the default), it printsWARNING … would refuseand exits 0 when UI files changed in this session, aplaywright.config.*whose directory holds them exists, and no record covers them in their current content. It records the case once;design-review.mjs would-refuselists these records for classification. - With
close-gate: refuse, the same case exits 3. - Not renderable, or not measurable: a
WARNINGand a record written bycheckitself. - No date and no automatic switch: the gate stays warn-only until
close-gate: refuseis set in a commit, and that is due only when (1) foreign commits pulled mid-session are no longer counted (third review of !413, H2) and this is independently re-reviewed, (2) the cold reader passes against owner judgements (agentic-designer#85), (3) at least 20 would-refuse cases are classified with at most 10 % wrong, and (4) step 5b has run once in a real wave with the realdesigner.
- With
- Change set: this session's own commits (
<start>..HEAD ^<default-branch baseline>, intersected with the net diff, and narrowed to the commits this worktree's HEAD reflog shows it created) plus the working tree. A rebase onto, or a merge of, an updated main, and a pull of a colleague's commits, never count other people's files; if the reflog cannot answer, the result is unmeasured, never a refusal. Commits with your git identity that are not attributed to this checkout (another worktree, clone or host, reset author date, squash, ambiguous author fingerprint) are named in a note and do not change the verdict. It never falls back toHEAD~1. STATE.md values older than this session's lock are ignored. Files last written before the session and deleted files do not count. - Records: they live in
.orchestrator/metrics/design-review.jsonl, keyed by worktree and session, not by branch.- Each record covers files by path and blob hash, so a later UI change re-arms the gate.
- They are written with a newline guard and read back. Unreadable lines and unknown setting values are named.
orchestrator.design_review.recordedcarries no free text and no paths.
- Record rules:
reviewedneeds reviewer, verdict, and untracked, non-empty PNG screenshots written in this session. ArecaptureorBLOCKEDreview is reported as "not judged".- A hand-made
not-reviewablein a repo that can render is reported like an override. owner-overriderecords actor and session kind. It is refused without an owner-queue--decisionin lead-guided (HUD steering file or--lead-guided), headless, CI and non-Claude-Code sessions.
- Reviewer:
session-reviewergets a short "UI and Copy" category. - Before: no UI check ran by default. The opt-in frontend-slop hook fired 0 times in 27,530 events, and across three product repos 58 of 262 UI and copy corrections were raised by the owner.
- Trigger: after an Impl-Core or Impl-Polish wave,
Changed
-
The full gate reports counted test failures behind a passing exit code (#2066, GH#93): when the test command exits 0 while its output counts failed tests, the gate prints one stderr line and sets
test.failed_despite_pass: truein its envelope. The verdict and the exit code still follow the test command's exit code. The hint appears only when the output carries aTestssummary line (vitest, jest); a pytest summary such as2 failed, 10 passed in 0.12sdoes not raise it. The count is read from free text and can be misread. -
The three read-only wave reviewers return their findings instead of writing a file (#2069, GH#90):
analyst,architect-reviewerandqa-strategistwere told to write.orchestrator/audits/wave-reviewer-<wave>-<name>.mdwithout a write tool. The coordinator writes that file now, andreport_pathis optional in the three output schemas. -
Seven skills no longer carry a
tools:frontmatter key (#2069, GH#90): Claude Code ignores the key, and the generated.agents/skillsand.codex-plugin/skillsmirrors turned it intoallowed-tools, a pre-approval nobody had decided on. The mirrors ofbrainstorm,debug,eli5,grill,tmux-layout,ux-grillandwrite-executable-planloseallowed-tools. -
test.modeno longer claims to block (#1452):docs/session-config-reference.mdsaidstrictblocks session-end on HIGH/CRITICAL findings. The value is parsed (parse-configreturns"mode":"strict", run against a fixture), but neither/test, test-runner nor session-end reads it, so the reference now says that. -
The pre-push hook lets a trusted-publishing probe tag through the mirror smoke gate (#1906): a commit pushed alone to
refs/tags/vX.Y.Z-<id>.Nongithubwhose single parent is a proven curated snapshot and which changes only the version fields ofpackage.jsonandpackage-lock.jsonto that version runsnpm run test:mirror, like the snapshot itself (scripts/lib/mirror-probe.mjs). Before, the route B rehearsal could not push its tag without a hook bypass, because such a tree is never the export tree of a source. -
The trusted-publishing workflow publishes a prerelease under its own dist-tag (#1906):
.github/workflows/publish.ymlrunsnpm publish --provenance --access public --tag <id>for a versionX.Y.Z-<id>.N(e.g.5.18.1-probe.0→ dist-tagprobe), solatestnever moves to it. OnlyX.Y.ZandX.Y.Z-<id>.Npublish (<id>lowercase, two or more characters, notlatest, not range-shaped likev1/vx); build metadata and npm loose forms (1.2.3beta.0) fail the run before npm normalises the version. This makes the first trusted publish, which npm needs to confirm a newly set-up Trusted Publisher, a rehearsal that cannot burn a release number.skills/npm-publish/SKILL.md§ Route B describes the rehearsal. A plainX.Y.Zpublishes as before.