Fixes #18820 - fill in CV id on components #6690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parthaa do you mind reviewing? |
parthaa
reviewed
Mar 21, 2017
| @@ -0,0 +1,10 @@ | |||
| class FillInContentViewComponents < ActiveRecord::Migration | |||
| def up | |||
| Katello::ContentViewComponent.find_each do |cvc| | |||
There was a problem hiding this comment.
Don't you need to define this model in the migration ?
|
@parthaa updated |
parthaa
reviewed
Mar 21, 2017
| class FakeContentView < ActiveRecord::Base | ||
| self.table_name = 'katello_content_views' | ||
|
|
||
| has_many :content_view_components, :class_name => "Katello::FakeContentViewVersion", :dependent => :destroy, |
There was a problem hiding this comment.
shouldnt this be something like FillInContentViewComponents::FakeContentViewVersion ?
during the migration to add latest to component content views, the content view id field is used but not populated during the migration.
|
ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during the migration to add latest to component
content views, the content view id field is used
but not populated during the migration.