-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recycle bin #57
Open
0x4f53
wants to merge
54
commits into
main
Choose a base branch
from
recycle_bin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Recycle bin #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totp length validation
Username and email display behavior
19 digit cards
Co-authored-by: Rohan Chaturvedi <rohan.chaturvedi@protonmail.com>
Revamped Keyspace settings to match Android 13 AOSP settings
Co-authored-by: Rohan Chaturvedi <rohan.chaturvedi@protonmail.com>
Crash logging
chore: bump version
…ties chore: delete local.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Accidents can happen when you're in a hurry. When you tap the delete button, the item is permanently deleted. If you do this on accident, you lose data forever.
💡 Proposed solution
Adding support for a "deleted items" feature, which kinda works like the
.Trash
directory on some Linux distros or Recycle Bin on Windows. This section lets you:📷 Screenshots
📚 Release Notes
KeyspaceFS changes
Added a boolean value called
deleted
to KeyspaceFS. This value is set tofalse
by default (for the first time / when an item is created). If the item is being edited, the trash icon appears on the editing screen. Tapping that icon sets the value to true after user confirmation, then writes that change toPUT
requestWhen the deleted items list is displayed, the vault is first sorted by recently edited items to (for obvious reasons).
UI changes
Added a new button called "Deleted items" to the user account menu on the Dashboard.
📝 Testing
Deleting an item
Restoring an item