Disable blending for VK_FORMAT_E5B9G9R9_UFLOAT_PACK32 on macOS Apple Silicon. #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VK_FORMAT_E5B9G9R9_UFLOAT_PACK32 on macOS Apple Silicon. On Apple Silicon (iOS/tvOs/macOS M1), format VK_FORMAT_E5B9G9R9_UFLOAT_PACK32 is fully supported as a color attachment except that format components cannot be individually write-enabled. All components must either be write-enabled or write-disabled together. This is causing several hundred Vulkan CTS blending tests to fail on M1. The least intrusive behavioural change to allow the CTS tests to report Not Supported instead, is to disable blending for this format.
cdavis5e
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BITforVK_FORMAT_E5B9G9R9_UFLOAT_PACK32on macOS Apple Silicon.On Apple Silicon (iOS/tvOs/macOS M1), format
VK_FORMAT_E5B9G9R9_UFLOAT_PACK32is fully supported as a color attachment except that format components cannot
be individually write-enabled. All components must either be write-enabled or
write-disabled together. This is causing several hundred Vulkan CTS blending
tests to fail on M1. The least intrusive behavioural change to allow the CTS
tests to report Not Supported instead, is to disable blending for this format.
Fixes KhronosGroup/Vulkan-Portability#28.