Advertise support for extension VK_KHR_spirv_1_4. #1724
Conversation
- Advertise support for extension VK_KHR_spirv_1_4. - MoltenVKShaderConverter automatically map bindings when converting GLSL. - MoltenVKShaderConverter improvements to diagnostic logging. - Update Whats_New.md document.
GitHub CI has deprecated and removed support for the macos-10.15 runner image.
| @@ -97,16 +98,25 @@ void mvk::logSPIRV(vector<uint32_t>& spirv, string& spvLog) { | |||
| uint32_t options = (SPV_BINARY_TO_TEXT_OPTION_INDENT); | |||
| spv_text text; | |||
| spv_diagnostic diagnostic = nullptr; | |||
| spv_context context = spvContextCreate(SPV_ENV_VULKAN_1_0); | |||
| spv_context context = spvContextCreate(SPV_ENV_VULKAN_1_2); | |||
There was a problem hiding this comment.
Doesn't that allow SPIR-V 1.5? I guess it doesn't really matter much at this point, given that this function just logs the SPIR-V it was given.
There was a problem hiding this comment.
According to KhronosGroup/SPIRV-Cross#2004 SPIRV-Cross now also supports 1.5, so this should be perfectly fine.
There was a problem hiding this comment.
Yes. That particular line change was primarily about allowing spirv-tools to log v1.4 (and v1.5) SPIR-V (I guess I could have identified that in the commit note).
And also yes. Both SPIR-V 1.4 and 1.5 are effectively supported by SPIRV-Cross now. There is no specific Vulkan extension to be identified to indicate SPIR-V 1.5 support in MoltenVK, otherwise this PR would have included that.
Next stop Vulkan 1.2!
VK_KHR_spirv_1_4.MoltenVKShaderConverterautomatically map bindings when converting GLSL.MoltenVKShaderConverterimprovements to diagnostic logging.Whats_New.mddocument.Support for SPIR-V 1.4 features added in recent updates to
SPRIV-Cross.