Add: KHR_shader_integer_dot_product #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhollings
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Thanks! LGTM once the SPIRV-Cross update is ready and added to this PR.
Also #1930 is not properly updated anymore.
I update that list once the PRs are merged into main. For instance, VK_KHR_format_feature_flags2 is checked now.
spnda
force-pushed
the
KHR_shader_integer_dot_product
branch
from
ec32b2e
to
0833a38
Compare
spnda
force-pushed
the
KHR_shader_integer_dot_product
branch
from
0833a38
to
6dbe768
Compare
spnda
force-pushed
the
KHR_shader_integer_dot_product
branch
from
6dbe768
to
151e940
Compare
|
@billhollings Just updated the SPIRV-Cross ref with Hans-Kristian's additional changes, this is good to go now. |
Thanks! Merged, and updated #1930. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires KhronosGroup/SPIRV-Cross#2257. I haven't updated the revision yet because of the outstanding PR.
Passes 100% of related CTS tests.
Also #1930 is not properly updated anymore.