Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification for cl_arm_scheduling_controls v0.2.0 #537

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

kpet
Copy link
Contributor

@kpet kpet commented Jan 7, 2021

Signed-off-by: Kevin Petit kevin.petit@arm.com

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
Change-Id: Id17db2280c27b81d58a2c5a093cf0375eea5ecd7
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

Do we need to add the bit for CL_DEVICE_SCHEDULING_DEFERRED_FLUSH_ARM to the XML file also?

@kpet
Copy link
Contributor Author

kpet commented Jan 19, 2021

Thanks for the review!

Yes, as well as other bit definitions for the CL_DEVICE_SCHEDULING_CONTROLS_CAPABILITIES_ARM query. There doesn't seem to be a precedent for anonymous bitmasks (the query returns cl_bitfield as opposed to a custom type). I'll fix this in the next version of the specification (probably by introducing an alias for cl_bitfield). It doesn't make any practical difference at present as the bit definitions aren't typed but it would certainly make it easier to improve type safety and automatic header generation in the future.

Merging as is for now.

@kpet kpet merged commit b994535 into KhronosGroup:master Jan 19, 2021
@kpet kpet deleted the cl_arm_scheduling_controls branch January 19, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants