Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL 4.6: SPIR-V and shader object type. #16

Closed
NicolBolas opened this issue Sep 15, 2017 · 5 comments
Closed

OpenGL 4.6: SPIR-V and shader object type. #16

NicolBolas opened this issue Sep 15, 2017 · 5 comments
Assignees

Comments

@NicolBolas
Copy link

When you create a shader object, it is passed the shader stage that it works with. But SPIR-V entry points serve the same function: each entry point specifies which shader stage it works with.

So, what happens if there is a mismatch when specializing a shader? That's not explicitly a failure mode of glSpecializeShader; it only says that the entry point must be "valid".

@ghost ghost assigned pdaniell-nv Oct 5, 2017
@dgkoch dgkoch assigned dgkoch and unassigned pdaniell-nv Oct 13, 2017
@dgkoch dgkoch assigned dgkoch and pdaniell-nv and unassigned dgkoch Nov 14, 2017
@dgkoch
Copy link

dgkoch commented Nov 14, 2017

I propose replacing the current error:

 INVALID_VALUE is generated if <pEntryPoint> does not name a valid
 entry point for <shader>.

with the following:

 INVALID_VALUE is generated if <pEntryPoint> does not match the
 <Name> of any OpEntryPoint declaration in the SPIR-V module
 associated with <shader>.

 INVALID_OPERATION is generated if the <Execution Mode> of the
 OpEntryPoint indicated by <pEntryPoint> does not match the type
 of <shader>.

@pdaniell-nv
Copy link

OpenGL|ES meeting approved. @dgkoch to create ARB extension PR and @oddhack to incorporate that change into core spec.

@dgkoch
Copy link

dgkoch commented Nov 15, 2017

PR for extension doc: KhronosGroup/OpenGL-Registry#129

Also filed CTS issue to make sure test for new error is added: https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/852

@dgkoch dgkoch assigned oddhack and unassigned dgkoch Nov 16, 2017
@dgkoch dgkoch added this to the Needs Action/PR milestone Nov 16, 2017
@dgkoch
Copy link

dgkoch commented Nov 16, 2017

Extension PR was merged. Assigning to @oddhack to incorporate the same change into the next GL 4.6 spec update.

@oddhack
Copy link
Contributor

oddhack commented Jan 23, 2018

This will be fixed in the next GL 4.6 spec update, coming soon.

@oddhack oddhack closed this as completed Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants